On 02/14/2018 07:34 AM, Stefan Hajnoczi wrote:
On Wed, Feb 14, 2018 at 09:01:11AM +0800, Fam Zheng wrote:
On Tue, 02/13 18:09, Daniel P. Berrangé wrote:
On Tue, Feb 13, 2018 at 05:34:25PM +0000, Stefan Hajnoczi wrote:
+[gitpublishprofile "block"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cc = qemu-bl...@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit
--nogit-fallback 2>/dev/null
Why is a custom entry needed for block here (and other things
below). Won't running get_maintainer.pl already correctly
report when a patch needs cc'ing to qemu-bl...@nongnu.org
based on MAINTAINER rules ?
Yeah, dropping them should be fine. What do you think, Stefan?
scripts/get_maintainer.pl only works when patches touch files associated
with qemu-bl...@nongnu.org in MAINTAINERS. It would be
counter-intuitive for --profile block to not include
qemu-bl...@nongnu.org, so I think these entries do serve a purpose.
More precisely, the cover letter does not touch any files, and git
doesn't know how to automatically cc the cover letter to any recipient
of any of the rest of the series. Having these entries ensures that the
cover letter goes to the right list (on the other hand, git publish
itself could be taught to be smarter about cc'ing the cover letter to
every email scraped from later in the series, even if git send-email
can't do that yet).
On the other hand, I personally just use --cc qemu-block instead of a
profile for this. I'll probably only use the default profile.
Fam, if you want it dropped, let me know. Otherwise, we can leave it
in if there is no further discussion.
Stefan
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
