Re: [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef

[Mark Cave-Ayland]

On 16/02/18 18:38, Peter Maydell wrote:

On 16 February 2018 at 17:31, Dr. David Alan Gilbert (git)
<dgilb...@redhat.com> wrote:

From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>

RHEL6's compilers don't like the repeated typedef.

Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
---
  include/hw/misc/macio/cuda.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/hw/misc/macio/cuda.h b/include/hw/misc/macio/cuda.h
index 6afbdd13ee..494b709579 100644
--- a/include/hw/misc/macio/cuda.h
+++ b/include/hw/misc/macio/cuda.h
@@ -93,12 +93,12 @@ typedef struct CUDAState {
  } CUDAState;

  /* MOS6522 CUDA */
-typedef struct MOS6522CUDAState {
+struct MOS6522CUDAState {
      /*< private >*/
      MOS6522State parent_obj;

      CUDAState *cuda;
-} MOS6522CUDAState;
+};

  #define TYPE_MOS6522_CUDA "mos6522-cuda"
  #define MOS6522_CUDA(obj) OBJECT_CHECK(MOS6522CUDAState, (obj), \
--

Thanks; applied to master as a  buildfix.

Thanks both. Apologies I got caught up later than expected yesterday.


ATB,

Mark.