On Thu, Mar 01, 2018 at 03:48:44PM +0000, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 04:44:33PM +0800, Peter Xu wrote: > > We have worked on qio_task_run_in_thread() already. Further, let > > qio_channel_socket_connect_async() pass that context to it. > > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > --- > > chardev/char-socket.c | 4 ++-- > > include/io/channel-socket.h | 4 +++- > > io/channel-socket.c | 5 +++-- > > migration/socket.c | 3 ++- > > tests/test-io-channel-socket.c | 2 +- > > 5 files changed, 11 insertions(+), 7 deletions(-) > > > diff --git a/include/io/channel-socket.h b/include/io/channel-socket.h > > index 53801f6042..90f7227397 100644 > > --- a/include/io/channel-socket.h > > +++ b/include/io/channel-socket.h > > @@ -101,6 +101,7 @@ int qio_channel_socket_connect_sync(QIOChannelSocket > > *ioc, > > * @callback: the function to invoke on completion > > * @opaque: user data to pass to @callback > > * @destroy: the function to free @opaque > > + * @context: the context to run the async task > > * > > * Attempt to connect to the address @addr. This method > > * will run in the background so the caller will regain > > @@ -113,7 +114,8 @@ void qio_channel_socket_connect_async(QIOChannelSocket > > *ioc, > > SocketAddress *addr, > > QIOTaskFunc callback, > > gpointer opaque, > > - GDestroyNotify destroy); > > + GDestroyNotify destroy, > > + GMainContext *context); > > If you're going to add a GMainContext() to connect_async, then please > also do it for listen_async and dgram_async at the same time, so we > remain consistent in API design.
Sure. Thanks, -- Peter Xu