On 03/23/2018 03:42 PM, Eduardo Habkost wrote:
On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote:
it will allow to reuse parse_NumaOptions() for parsing
configuration commands received via QMP interface
Signed-off-by: Igor Mammedov <imamm...@redhat.com>
---
end:
+ if (err) {
+ error_propagate(errp, err);
+ }
"if (err)" is not necessary here. See
scripts/coccinelle/error_propagate_null.cocci.
+ parse_NumaOptions(ms, object, &err);
+
+end:
qapi_free_NumaOptions(object);
if (err) {
error_report_err(err);
We can fix this one too while at it.
Hmm - this is the same script mentioned here:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06293.html
Except that patch didn't pick up this file. Why is Coccinelle not
seeing this?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
