On Fri, Mar 23, 2018 at 03:49:38PM -0500, Eric Blake wrote: > On 03/23/2018 03:42 PM, Eduardo Habkost wrote: > > On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote: > > > it will allow to reuse parse_NumaOptions() for parsing > > > configuration commands received via QMP interface > > > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > > --- > > > > end: > > > + if (err) { > > > + error_propagate(errp, err); > > > + } > > > > "if (err)" is not necessary here. See > > scripts/coccinelle/error_propagate_null.cocci. > > > > > > + parse_NumaOptions(ms, object, &err); > > > + > > > +end: > > > qapi_free_NumaOptions(object); > > > if (err) { > > > error_report_err(err); > > > > We can fix this one too while at it. > > Hmm - this is the same script mentioned here: > https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06293.html > > Except that patch didn't pick up this file. Why is Coccinelle not seeing > this?
I don't know. I've seen Coccinelle being confused by some of our preprocessor magic before, and in those cases it simply skipped some files. -- Eduardo