Hello,
I'm sorry I didn't find the time to have a look at it before.
In general it looks good, just a few things:
Samuel
Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit:
> + if (!net_hub_id_for_client(&s->nc, &vlan)) {
That makes me think that IIUC, we shouldn't call them vlan, as mentioned
in the recent vlan->hub renaming patches.
> +{ 'struct': 'UsernetInfo',
> + 'data': {
> + 'id': 'str',
> + 'vlan': 'int',
and here as well, I guess.
> +void slirp_connection_info(Slirp *slirp, Monitor *mon)
> +{
> + const char *state;
> + char buf[64];
> + UsernetInfo info = { };
> + UsernetConnectionList *cl;
> +
> + monitor_printf(mon, " Protocol[State] FD Source Address Port "
> + "Dest. Address Port RecvQ SendQ\n");
> +
> + usernet_get_info(slirp, &info);
Mmm, I don't see the content of info being freed here?
Samuel
