Fam Zheng, le mer. 02 mai 2018 15:29:36 +0800, a ecrit: > On Tue, 05/01 22:41, Samuel Thibault wrote: > > I'm sorry I didn't find the time to have a look at it before. > > > > In general it looks good, just a few things: > > > > Samuel > > > > Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit: > > > + if (!net_hub_id_for_client(&s->nc, &vlan)) { > > > > That makes me think that IIUC, we shouldn't call them vlan, as mentioned > > in the recent vlan->hub renaming patches. > > > > > +{ 'struct': 'UsernetInfo', > > > + 'data': { > > > + 'id': 'str', > > > + 'vlan': 'int', > > > > and here as well, I guess. > > OK, so rename this to hub? (I'm not familiar with the naming issue you pointed > out).
I am not either :) Please check with the thread http://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg02126.html Samuel