Daniel P. Berrangé <berra...@redhat.com> wrote: > On Wed, Apr 04, 2018 at 01:27:24PM +0200, Juan Quintela wrote: >> Migration code needs that function in hmp.c (so we need to export it), >> and it needs it on tests/migration-test.c, so we need to move it to a >> place where it is compiled into the test framework. > > This code really does not belong in qemu-sockets.h - the syntax being > printed here is the chardev specific syntax, hence those is_listen and > is_telnet parameters. If we want a way to string-ify SocketAddress then > it should be a generic format, not the chardev format.
Hi Dropeed. Don't make sense to try to generalize it for two users. Just copy to hmp.c one simplified copy. Thanks, Juan.
