Re: [Qemu-devel] [RFC PATCH 02/12] qcow2/dirty-bitmap: cache loaded bitmaps

[Vladimir Sementsov-Ogievskiy]

12.05.2018 04:25, John Snow wrote:
For bitmaps that we succeeded in loading, we can cache a reference
to that object. This will let us iterate over the more convenient
form of in-memory bitmaps for qemu-img bitmap manipulation tools.
Signed-off-by: John Snow <js...@redhat.com>
---
  block/qcow2-bitmap.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index fb0a4f3ec4..d89758f235 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -986,6 +986,7 @@ bool qcow2_load_dirty_bitmaps(BlockDriverState *bs, Error 
**errp)
              if (bitmap == NULL) {
                  goto fail;
              }
+            bm->dirty_bitmap = bitmap;
  
              if (!(bm->flags & BME_FLAG_AUTO)) {
                  bdrv_disable_dirty_bitmap(bitmap);

Looks correct, I just suppose to reuse this information somehow in 
qcow2_store_persistent_dirty_bitmaps, at least for an assert.

--
Best regards,
Vladimir