On 05/14/2018 08:55 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.05.2018 04:25, John Snow wrote: >> For the purposes of qemu-img manipulation and querying of bitmaps, load >> bitmaps that are "in use" -- if the image is read only. This will allow >> us to diagnose problems with this flag using the qemu-img tool. > > It looks unsafe.. We can load them, then reopen rw and then store them > on vm close, the result would be unpredictable. And they become > available for qmp commands.. > > If we want to load them, we may need some additional state for such > dirty bitmaps, something like "invalid", to be sure, that they will not > be used like normal bitmap. And we may > need some additional flag to load or not load them, and this behavior > will be unrelated to can_write(). >
Yeah, you're right -- reopening is scary. I'll see what I can do. The goal is just to get them in memory so that qemu-img can use the standard BdrvDirtyBitmap API to print various info about them for the user. Since 'info' and 'dump' don't need RW access, it'd be nicest for these commands to work in RO mode, hence the patch.
