On 05/15/2018 10:04 AM, Peter Maydell wrote:
I'd much prefer this to be:
if $strings -a $TMPO | grep...
That's because if I have something like this in my environment:
STRINGS='/path/to/strings -a'
it will only work if you allow word splitting on my variable.
Conversely, if I have STRINGS='/path with spaces/to/strings'
in my environment it will only work if you don't do word
splitting on it :-)
Make convention has long been that /path with spaces/ is unacceptable
for any of the typical tool replacements, and that you always perform
unquoted (and thus word splitting) of a tool name. My most common
example is EDITOR='emacs -nw'. You can always add a symlink to a tool
from a path without spaces, if you want to provide a tool override to
something that normally lives somewhere with spaces.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
