On Tue, May 15, 2018 at 05:56:34PM +0200, Markus Armbruster wrote: [...]
> I see. > > Add a contract comment (suggest to start with the one next to > error_report()), expand the tabs, replace the reserved identifiers > (caught by patchew; you can use foo_ instead of __foo), throw in at > least one use to serve as a showcase (ideally one demonstrating the > difference to trace points), and consider working some of your > additional rationale into your commit message. Will do. Thanks Markus. -- Peter Xu