On 2011-02-07 16:13, Avi Kivity wrote: > On 02/07/2011 05:01 PM, Anthony Liguori wrote: >> >> typedef struct PeriodicTimer PeriodicTimer; >> >> /** >> * @accumulated_ticks: the number of unacknowledged ticks in total >> since the creation of the timer >> **/ > > Outdated comment even before the code is committed. Will be hard to beat. > >> typedef void (PeriodicTimerFunc)(void *opaque); > > s/void *opaque/PeriodicTimer *timer/ > > Down with opaques!
What else? DeviceState? > >> >> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque); >> > > void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb); > > It is better to embed than to reference. Likely, though this diverges from exiting QEMUTimer. BTW, QEMUClock argument is missing in new/init. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
