On 02/07/2011 09:20 AM, Jan Kiszka wrote:
On 2011-02-07 16:13, Avi Kivity wrote:
PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque);

void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb);

It is better to embed than to reference.
And embedding means making the layout (at least the size) of
PeriodicTimer public. I guess that's why QEMUTimer works via new.

Yeah, QEMU generally follows a construction-is-allocation model.

Regards,

Anthony Liguori

Jan



Reply via email to