On 30 June 2018 at 10:13, Stefan Hajnoczi <stefa...@redhat.com> wrote: > The ARMv7-M code is largely similar to what other M Profile CPUs need. > Extract the common M Profile aspects into the ARMMProfileState base > class. ARMv6-M will inherit from this class in the following patch. > > It might be possible to make ARMv6-M the base class of ARMv7-M, but it > seems cleaner to have an M Profile base class instead of saying an > "ARMv7-M is an ARMv6-M". > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
This makes sense, I guess (though it currently leaves us in the odd position that we have separate a object for v6m, but the v7m object handles both v7m and v8m...) > /** > - * armv7m_load_kernel: > + * arm_m_profile_load_kernel: > * @cpu: CPU > * @kernel_filename: file to load > - * @mem_size: mem_size: maximum image size to load > + * @mem_size: maximum image size to load > * > - * Load the guest image for an ARMv7M system. This must be called by > - * any ARMv7M board. (This is necessary to ensure that the CPU resets > + * Load the guest image for an ARM M Profile system. This must be called by > + * any ARM M Profile board. (This is necessary to ensure that the CPU resets > * correctly on system reset, as well as for kernel loading.) > */ > -void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int > mem_size); > +void arm_m_profile_load_kernel(ARMCPU *cpu, const char *kernel_filename, > + int mem_size); This is presumably just a code movement and rename, but it's a bit hard to confirm that. Could you split it out into its own patch, please? thanks -- PMM