* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Based-on: <20180627132246.5576-1-pet...@redhat.com> > > > > Based on the series to unbreak postcopy: > > Subject: [PATCH v3 0/4] migation: unbreak postcopy recovery > > Message-Id: <20180627132246.5576-1-pet...@redhat.com> > > > > This series introduce a new postcopy recovery test. The new test > > actually helped me to identify two bugs there so fix them as well > > before 3.0 release. > > > > Patch 1: a trivial cleanup for existing postcopy ram load, which I > > found a bit confusing during debugging the problem. > > > > Patch 2-3: two bug fixes that address different issues. Please see > > the commit log for more information. > > > > Patch 4-9: add the postcopy recovery unit test. > > > > Please review. Thanks, > > Queued
Hi Peter, There's a problem in there somewhere; I'm getting an intermittent failure of the test if I run a make check -j 8 on my laptop. Just running two copies of tests/migration-test in parallel sometimes triggers it (but not if I turn on QTEST_LOG!). But it's always failing with: ERROR:/home/dgilbert/git/migpull/tests/migration-test.c:373:migrate_recover: assertion failed: (qdict_haskey(rsp, "return")) Dave > > Peter Xu (9): > > migration: simplify check to use qemu file buffer > > migration: loosen recovery check when load vm > > migration: fix incorrect bitmap size calculation > > tests: introduce migrate_postcopy_* helpers > > tests: allow migrate() to take extra flags > > tests: introduce migrate_query*() helpers > > tests: introduce wait_for_migration_status() > > tests: add postcopy recovery test > > tests: hide stderr for postcopy recovery test > > > > migration/ram.c | 21 +++-- > > migration/savevm.c | 16 ++-- > > tests/migration-test.c | 198 ++++++++++++++++++++++++++++++++--------- > > 3 files changed, 176 insertions(+), 59 deletions(-) > > > > -- > > 2.17.1 > > > > > -- > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
