On Thu, Jul 05, 2018 at 11:17:46AM +0800, Peter Xu wrote: > Based-on: <20180627132246.5576-1-pet...@redhat.com> > > Based on the series to unbreak postcopy: > Subject: [PATCH v3 0/4] migation: unbreak postcopy recovery > Message-Id: <20180627132246.5576-1-pet...@redhat.com> > > This series introduce a new postcopy recovery test. The new test > actually helped me to identify two bugs there so fix them as well > before 3.0 release. > > Patch 1: a trivial cleanup for existing postcopy ram load, which I > found a bit confusing during debugging the problem. > > Patch 2-3: two bug fixes that address different issues. Please see > the commit log for more information. > > Patch 4-9: add the postcopy recovery unit test. > > Please review. Thanks,
Hi Peter, Dave, I am sorry, I have missed to include Peter's postcopy-recover fix patchset, migration: delay postcopy paused state migration: move income process out of multifd migration: unbreak postcopy recovery migration: unify incoming processing Postcopy migration with pause and recover is working fine. # QTEST_QEMU_BINARY=./ppc64-softmmu/qemu-system-ppc64 # ./tests/migration-test /ppc64/migration/deprecated: OK /ppc64/migration/bad_dest: OK /ppc64/migration/postcopy/unix: OK /ppc64/migration/postcopy/recovery: OK /ppc64/migration/precopy/unix: OK But qtest patches in this patchset have to be rebased as commit 5fd4a9c97397bc0819a919de7a62ec972ec85260 (tests/migration: Skip tests for ppc tcg) have gone in. # git am ../postcopy_pause/4.patch Applying: tests: introduce migrate_postcopy_* helpers error: patch failed: tests/migration-test.c:351 error: tests/migration-test.c: patch does not apply Patch failed at 0001 tests: introduce migrate_postcopy_* helpers The copy of the patch that failed is found in: /home/bala/qemu/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". I have manually reverted it to apply and test your patchset. This Patchset is working without any issues. Tested-by: Balamuruhan S <bal...@linux.vnet.ibm.com> > > Peter Xu (9): > migration: simplify check to use qemu file buffer > migration: loosen recovery check when load vm > migration: fix incorrect bitmap size calculation > tests: introduce migrate_postcopy_* helpers > tests: allow migrate() to take extra flags > tests: introduce migrate_query*() helpers > tests: introduce wait_for_migration_status() > tests: add postcopy recovery test > tests: hide stderr for postcopy recovery test > > migration/ram.c | 21 +++-- > migration/savevm.c | 16 ++-- > tests/migration-test.c | 198 ++++++++++++++++++++++++++++++++--------- > 3 files changed, 176 insertions(+), 59 deletions(-) > > -- > 2.17.1 > >