Hi, Paolo,
It was an incredibly fast fix! :)
I already confirmed that the fix fixes the problem on msa_helper.c. I would
nevertheless like to have this workaround applied. Can you perhaps give it
"Reviewed-by"?
Regards,
Aleksandar
> Subject: [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on
> > msa_helper.c
>
> From: Aleksandar Markovic <amarko...@wavecomp.com>
>
> If checkpatch.pl is applied (using switch "-f") on file
> target/mips/msa_helper.c, it will hang.
>
> This is a workaround by correcting the source file. The workaround is
> found by partial deleting and undeleting of the code in msa_helper.c
> in binary search fashion.
>
> The bug (for checkpatch.pl) is already reported to the qemu-devel list.
>
> Signed-off-by: Aleksandar Markovic <amarko...@wavecomp.com>
> ---
> target/mips/msa_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c
> index c74e3cd..1691b70 100644
> --- a/target/mips/msa_helper.c
> +++ b/target/mips/msa_helper.c
> @@ -2750,8 +2750,8 @@ void helper_msa_ftq_df(CPUMIPSState *env, uint32_t df,
> > uint32_t wd,
>
> #define FMAXMIN_A(F, G, X, _S, _T, BITS, STATUS) \
> do { \
> - uint## BITS ##_t S = _S, T = _T; \
> - uint## BITS ##_t as, at, xs, xt, xd; \
> + uint## BITS ## _t S = _S, T = _T; \
> + uint## BITS ## _t as, at, xs, xt, xd; \
> if (NUMBER_QNAN_PAIR(S, T, BITS, STATUS)) { \
> T = S; \
> } \
> --
> 2.7.4
