> I'm not sure it's worth having this but you are the maintainer so your > choice :)
If someone in future peruses an older version of this file (let's say, while working on an older version of QEMU), and comes across this problem with checkpatch.pl, by checking the full history of the file, they would be able to see what the problem is. Without this patch, they wouldn't. > What is unclear to me is, while changing this, why only fix > the suffix and not also the prefix? That is: > > uint<space>## BITS ##<space>_t S = _S, T = _T; It wouldn't be clear what characters caused the problem (or triggered the bug, if you wish). Regards, Aleksandar
