On Tue, Jul 31, 2018 at 04:48:35PM +0200, Juan Quintela wrote: > "Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > > * Li Qiang (liq...@gmail.com) wrote: > >> The default max cpu throttle is 99, this is too big that may > >> influence the guest loads. Add a qmp to config it can make it > >> more flexible. > >> > >> Signed-off-by: Li Qiang <liq...@gmail.com> > > > > This should be done as a migration parameter rather than a new command. > > For example, follow the cpu-throttle-increment parameter; and this > > should work just like it. > > I was about to comment this one. > > migrate_set_downtime, migrate_set_speed, migrate-set-cache-size, > query-migrate-cache-size are marked as deprecated. Any way that we > could have make more clear that one should use > migrate_set/get_parameter/capability?
Where are they marked as deprecated ? They're not included in our official list of deprecated features, so per our deprecation policy, they are still considered supported. https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features To deprecate something it needs to be added to qemu-deprecated.texi, and ideally also made to print a message to stderr when triggered. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|