Daniel P. Berrangé <berra...@redhat.com> wrote: > On Tue, Jul 31, 2018 at 04:48:35PM +0200, Juan Quintela wrote: >> "Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: >> > * Li Qiang (liq...@gmail.com) wrote: >> >> The default max cpu throttle is 99, this is too big that may >> >> influence the guest loads. Add a qmp to config it can make it >> >> more flexible. >> >> >> >> Signed-off-by: Li Qiang <liq...@gmail.com> >> > >> > This should be done as a migration parameter rather than a new command. >> > For example, follow the cpu-throttle-increment parameter; and this >> > should work just like it. >> >> I was about to comment this one. >> >> migrate_set_downtime, migrate_set_speed, migrate-set-cache-size, >> query-migrate-cache-size are marked as deprecated. Any way that we >> could have make more clear that one should use >> migrate_set/get_parameter/capability? > > Where are they marked as deprecated ?
## # @migrate_set_downtime: # # Set maximum tolerated downtime for migration. # # @value: maximum downtime in seconds # # Returns: nothing on success # # Notes: This command is deprecated in favor of 'migrate-set-parameters' # # Since: 0.14.0 # # Example: # # -> { "execute": "migrate_set_downtime", "arguments": { "value": 0.1 } } # <- { "return": {} } # ## { 'command': 'migrate_set_downtime', 'data': {'value': 'number'} } Notes: field. Clearly we need to do still more work there. Will change the texi, thanks. > > They're not included in our official list of deprecated features, so per > our deprecation policy, they are still considered supported. > > https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features > > To deprecate something it needs to be added to qemu-deprecated.texi, and > ideally also made to print a message to stderr when triggered. will send a patch to add to the texi and the print to stderr, thanks.