On 16 February 2011 17:59, <christophe.l...@st.com> wrote: > From: Christophe Lyon <christophe.l...@st.com> > > These special values are needed to implement some helper functions, > which return these values in some cases. > > This patch also moves the definitions of default_nan for 16, 64, x80 > and 128 bits floats for consistency with float32. > > Signed-off-by: Christophe Lyon <christophe.l...@st.com>
I'm happy enough with this patch; I think it's reasonable for target code to want to be able to get at the default NaN value without having to redefine it locally, so the move of stuff out of softfloat-specialize.h is OK. Arguable points: * should we have versions of float32_infinity and float32_set_sign() for the other float* types? * should those be in a separate patch from "move all the default NaN code"? but I don't have a very strong opinion either way on those, so unless somebody else (Aurelien?) wants to weigh in this is fine by me. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>