On 09/26/18 13:12, Laszlo Ersek wrote: > (4) append a new patch, for "bios-tables-test", so that the ACPI gen > change is validated as part of the test suite, on SeaBIOS/q35. > > Regarding (4): > > - is it OK if I add the test only for Q35? > > - what guest RAM size am I allowed to use in the test suite? In my own > SeaBIOS/Q35 reproducer I currently use 5GB, but I'm not sure if it's > acceptable for the test suite.
And, even if the patch's effect can be shown with little guest DRAM, the test case still requires a multi-gig ivshmem-plain device. In "tests/ivshmem-test.c", I see how it is set up -- the backend is set up with shm_open(). The file created under /dev/shm (on Linux) might require host RAM just the same as normal guest DRAM (especially with memory overcommit disabled on the host), correct? Thanks Laszlo
