On 10/4/18 12:48 PM, Eric Blake wrote: > On 10/4/18 11:18 AM, Cleber Rosa wrote: >> A trivial comment typo fix. >> >> Signed-off-by: Cleber Rosa <cr...@redhat.com> >> --- >> qemu-img.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index b12f4cd19b..a96b76c187 100644 >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -1085,7 +1085,7 @@ static int64_t find_nonzero(const uint8_t *buf, >> int64_t n) >> } >> /* >> - * Returns true iff the first sector pointed to by 'buf' contains at >> least >> + * Returns true if the first sector pointed to by 'buf' contains at >> least > > NACK. You're not the first person to propose this change. However, > "iff" is an English word (albeit archaic) which is shorthand for "if and > only if", which has a distinct logical meaning separate from the weaker > "if". Spelling it out in longhand instead of calling it a typo is > probably acceptable, though. > Wow, thanks for the explanation. I agree that spelling it out is a good option, as it'll probably prevent other people from falling into the same "language trap" as I did. Thanks! - Cleber.
- Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: ... Eric Blake
- Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: ... Philippe Mathieu-Daudé
- Re: [Qemu-devel] [PATCH 03/10] qemu-iotes... Cleber Rosa
- Re: [Qemu-devel] [PATCH 03/10] qemu-i... Eric Blake
- Re: [Qemu-devel] [PATCH 03/10] qe... Eric Blake
- [Qemu-devel] [PATCH 02/10] tests/tcg/README: fix l... Cleber Rosa
- Re: [Qemu-devel] [PATCH 02/10] tests/tcg/READ... Thomas Huth
- Re: [Qemu-devel] [PATCH 02/10] tests/tcg/READ... Alex Bennée
- [Qemu-devel] [PATCH 01/10] qemu-img.c: comment typ... Cleber Rosa
- Re: [Qemu-devel] [PATCH 01/10] qemu-img.c: co... Eric Blake
- Re: [Qemu-devel] [PATCH 01/10] qemu-img.c... Cleber Rosa
- Re: [Qemu-devel] [PATCH 01/10] qemu-i... Philippe Mathieu-Daudé
- Re: [Qemu-devel] [PATCH 01/10] qemu-img.c... Peter Maydell
- [Qemu-devel] [PATCH 07/10] scripts/decodetree.py: ... Cleber Rosa
- Re: [Qemu-devel] [PATCH 07/10] scripts/decode... Philippe Mathieu-Daudé
- [Qemu-devel] [PATCH 05/10] docs/devel/testing.rst:... Cleber Rosa
- [Qemu-devel] [PATCH 09/10] scripts/qemu.py: use a ... Cleber Rosa
- Re: [Qemu-devel] [PATCH 09/10] scripts/qemu.p... Eric Blake
- Re: [Qemu-devel] [PATCH 09/10] scripts/qe... Cleber Rosa
- Re: [Qemu-devel] [Qemu-block] [PATCH 09/10] s... John Snow