On 22 October 2018 at 18:35, Edgar E. Iglesias <edgar.igles...@gmail.com> wrote:
> From: "Edgar E. Iglesias" <edgar.igles...@xilinx.com>
>
> Add a virtual Xilinx Versal board.
>
> This board is based on the Xilinx Versal SoC. The exact
> details of what peripherals are attached to this board
> will remain in control of QEMU. QEMU will generate an
> FDT on the fly for Linux and other software to auto-discover
> peripherals.
>
> Signed-off-by: Edgar E. Iglesias <edgar.igles...@xilinx.com>
> +static void fdt_add_fixed_link_nodes(VersalVirt *s, char *gemname,
> + uint32_t phandle)
> +{
> + char *name = g_strdup_printf("%s/fixed-link", gemname);
> +
> + qemu_fdt_add_subnode(s->fdt, name);
> + qemu_fdt_setprop_cell(s->fdt, name, "phandle", phandle);
> + qemu_fdt_setprop_cells(s->fdt, name, "full-duplex");
Hi. This fails to compile in a non-debug build:
In file included from /home/peter.maydell/qemu/hw/arm/xlnx-versal-virt.c:16:0:
/home/peter.maydell/qemu/hw/arm/xlnx-versal-virt.c: In function
'fdt_add_fixed_link_nodes':
/home/peter.maydell/qemu/include/sysemu/device_tree.h:110:23: error:
comparison of unsigned expression < 0 is always false
[-Werror=type-limits]
for (i = 0; i < ARRAY_SIZE(qdt_tmp); i++) { \
^
/home/peter.maydell/qemu/hw/arm/xlnx-versal-virt.c:191:5: note: in
expansion of macro 'qemu_fdt_setprop_cells'
qemu_fdt_setprop_cells(s->fdt, name, "full-duplex");
^
because qemu_fdt_setprop_cells() requires you to provide
at least one cell value for the property being set.
What was the intention here ?
> + qemu_fdt_setprop_cell(s->fdt, name, "speed", 1000);
> + g_free(name);
> +}
In the meantime, I'm dropping the versal patches from
target-arm.next.
thanks
-- PMM
