On 2018-11-01 03:12, Zhang Chen wrote: > This compilation issue will occur when user use --disable-replication > to config Qemu. > > Reported-by: Thomas Huth <th...@redhat.com> > Signed-off-by: Zhang Chen <zhangc...@gmail.com> > --- > migration/colo.c | 28 +++++++++++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-)
Thanks, this fixes the compilation problem with --disable-replication for me: Tested-by: Thomas Huth <th...@redhat.com> BTW, if colo can't be used without CONFIG_REPLICATION, would it make sense to disable the related objects (for the "--object" parameter) in an additional patch, too? Something like this (untested): diff --git a/net/Makefile.objs b/net/Makefile.objs --- a/net/Makefile.objs +++ b/net/Makefile.objs @@ -10,7 +10,7 @@ common-obj-$(CONFIG_NETMAP) += netmap.o common-obj-y += filter.o common-obj-y += filter-buffer.o common-obj-y += filter-mirror.o -common-obj-y += colo-compare.o +common-obj-$(CONFIG_REPLICATION) += colo-compare.o common-obj-y += colo.o common-obj-y += filter-rewriter.o common-obj-y += filter-replay.o Thomas
