On 19/11/18 19:14, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 06:14:26PM +0100, Paolo Bonzini wrote: >> On 19/11/18 16:31, Igor Mammedov wrote: >>> I've tried to give suggestions how to restructure series >>> on per patch basis. In my opinion it quite possible to split >>> series in several smaller ones and it should really help with >>> making series cleaner and easier/faster to review/amend/merge >>> vs what we have in v5. >> >> This is true, on the other hand the series makes sense together and, >> even if the patches are more or less independent, they also all follow >> the same "plan". For reviewing v6, are you aware of Patchew's series >> diff functionality? It can tell you which patches had comments in v5, >> reorder patches if applicable, and display deleted and new patches at >> the right point in the series. >> >> v4->v5 is a bit messed up because Samuel probably added a diff order >> setup >> (https://patchew.org/QEMU/20181101102303.16439-1-sa...@linux.intel.com/diff/20181105014047.26447-1-sa...@linux.intel.com/) >> but it's very useful in general. >> >> Paolo > > Oh I didn't realize difforder breaks patchew. Or is the problem > only if one switches from no order to difforder?
No, it's just that switching it on makes the inter-version diff much larger, because all hunks are reordered. difforder is not a problem. Paolo
