On 14.12.2018 14:08, Thomas Huth wrote:
> The time2tod() function tries to deal with the 9 uppermost bits in the
> time value, but uses the wrong mask for this: 0xff80000000000000 should
> be used instead of 0xff10000000000000 here.
>
> Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd
Can you alsways have commit id and subject
like
Fixes: 14055ce53c2d ("s390x/tcg: avoid overflows in time2tod/tod2time")
> Signed-off-by: Thomas Huth <th...@redhat.com>
> ---
> include/hw/s390x/tod.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/s390x/tod.h b/include/hw/s390x/tod.h
> index cbd7552..47ef9de 100644
> --- a/include/hw/s390x/tod.h
> +++ b/include/hw/s390x/tod.h
> @@ -56,7 +56,7 @@ typedef struct S390TODClass {
> /* Converts ns to s390's clock format */
> static inline uint64_t time2tod(uint64_t ns)
> {
> - return (ns << 9) / 125 + (((ns & 0xff10000000000000ull) / 125) << 9);
> + return (ns << 9) / 125 + (((ns & 0xff80000000000000ull) / 125) << 9);
> }
>
> /* Converts s390's clock format to ns */
>
