On 2018-12-14 14:15, Christian Borntraeger wrote: > > > On 14.12.2018 14:08, Thomas Huth wrote: >> The time2tod() function tries to deal with the 9 uppermost bits in the >> time value, but uses the wrong mask for this: 0xff80000000000000 should >> be used instead of 0xff10000000000000 here. >> >> Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd > > Can you alsways have commit id and subject > > like > Fixes: 14055ce53c2d ("s390x/tcg: avoid overflows in time2tod/tod2time")
In https://wiki.qemu.org/Contribute/SubmitAPatch we currently have: Fixes: <full-SHA-commit-id> ... and the full commit ID is sometimes very useful for downstream, so I'd rather avoid to abbreviate that here. But I can try to remember to put the title of the patch in another spot of the description, too. Thomas