On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > > > On 1/2/19 12:01 PM, Christophe Fergeau wrote: > >> Adding Markus to cc: list, I forgot to do it when sending the patch. > > > > Also worth backporting via qemu-stable, now in cc. > > > >> > >> Christophe > >> > >> On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote: > >>> commit 8bca4613 added support for %% in json strings when interpolating, > >>> but in doing so, this broke handling of % when not interpolating as the > >>> '%' is skipped in both cases. > >>> This commit ensures we only try to handle %% when interpolating. > > Impact? > > If you're unable to assess, could you give us at least a reproducer?
This all came from https://lists.freedesktop.org/archives/spice-devel/2018-December/046644.html Setting up a VM with libvirt with <graphics type='spice' autoport='yes' passwd='password%'/> fails to start with: qemu-system-x86_64: qobject/json-parser.c:146: parse_string: Assertion `*ptr' failed. If you use 'password%%' as the password instead, when trying to connect to the VM, you type 'password%' as the password instead of 'password%%' as configured in the domain XML. Christophe
signature.asc
Description: PGP signature