Hi Eric, On Tue, Jan 15, 2019 at 01:12:21PM -0600, Eric Blake wrote: > On 1/15/19 12:57 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote: > >> Use pvh.bin option rom when we are booting an uncompressed > >> kernel using the x86/HVM direct boot ABI. > >> > >> Signed-off-by: Stefano Garzarella <sgarz...@redhat.com> > >> Based-on: <1545422632-24444-5-git-send-email-liam.merw...@oracle.com> > > > > I don't think this is a great way to give attribution. > > Can you pls include the author name and the S.O.B from there as well? > > > > > >> --- > > Patchew understands Based-on: tags as meaning a prerequisite patch on > the list that must be applied first before this patch can apply (and NOT > in the sense that this patch is an updated revision to replace an > earlier revision posted by someone else) - but when using the annotation > to keep Patchew happy, it should either be in a 0/N cover letter, or for > a single patch, after the --- separator, as the condition of a > prerequisite patch not being applied is a transient condition relevant > to the current build but not something that needs to be recorded in > long-term git history. >
Thank you very much for the explanation! I'll move the Based-on tag in the cover letter. Cheers, Stefano
