Hi Liam, On Wed, Jan 16, 2019 at 10:16:04AM +0000, Liam Merwick wrote: > Hi Stefano, > > Code LGTM, just a few minor comments below > > On 15/01/2019 10:00, Stefano Garzarella wrote: > > The new pvh.bin option rom can be used with SeaBIOS to boot > > uncompressed kernel using the x86/HVM direct boot ABI. > > > > pvh.S contains the entry point of the option rom. It runs > > in real mode, loads the e820 table querying the BIOS, and > > then it switches to 32bit protect mode and jump to the > > "protect" -> "protected" > "jump" -> "jumps" >
Thanks! > > diff --git a/pc-bios/optionrom/pvh_main.c b/pc-bios/optionrom/pvh_main.c > > + > > +asm (".code32"); /* this code will be executed in protect mode */ > > > "protect" -> "protected" > > Thanks! > > + > > +struct hvm_start_info start_info; > > Can this be static? > Yes. > > +struct hvm_modlist_entry ramdisk_mod; > > Is this used? > Thanks, I forgot to remove it. I'm using it for initrd, but of course is not used in this patch. > > +uint8_t cmdline_buffer[CMDLINE_BUFSIZE]; > > Can this be static? > Yes. I'll include these changes in v3. Thanks, Stefano -- Stefano Garzarella Red Hat