On 24/01/19 03:38, BALATON Zoltan wrote: >> >> I started looking at this, and found two bugs in current code >> (unreachable devices that shouldn't be there - SERIAL_ISA for ARM, >> ACPI_NVDIMM for MIPS). There are a few issues in that the script is not > > The ACPI_NVDIMM for MIPS is pulled in by CONFIG_VT82C686 which needs > ACPI which needs NVDIMM even though it's probably not used. At least I > think so, I haven't tested if it could be removed.
Oh, you're right. The functions exported by hw/acpi/nvdimm.o are called by hw/i386/pc.c, hw/i386/pc_piix.c, hw/i386/pc_q35.c, hw/acpi/nvdimm.c, hw/acpi/piix4.c (piix4_device_plug_cb), hw/i386/acpi-build.c. hw/acpi/piix4.c indeed is used by Malta. I'll change it so that the symbol is selected by CONFIG_ACPI_X86. Maybe
