On Thu, Jan 24, 2019 at 01:51:58PM +0100, Thomas Huth wrote: > On 2019-01-23 07:56, Yang Zhong wrote: > > Signed-off-by: Yang Zhong <yang.zh...@intel.com> > > Reviewed-by: Thomas Huth <th...@redhat.com> > > --- > > default-configs/i386-softmmu.mak | 1 - > > default-configs/s390x-softmmu.mak | 1 - > > default-configs/virtio.mak | 15 --------------- > > hw/9pfs/Kconfig | 2 ++ > > hw/block/Kconfig | 2 ++ > > hw/char/Kconfig | 2 ++ > > hw/display/Kconfig | 5 +++++ > > hw/input/Kconfig | 2 ++ > > hw/net/Kconfig | 2 ++ > > hw/pci-host/Kconfig | 2 ++ > > hw/scsi/Kconfig | 1 + > > hw/virtio/Kconfig | 9 ++++++++- > > 12 files changed, 26 insertions(+), 18 deletions(-) > > delete mode 100644 default-configs/virtio.mak > > This breaks compilation of aarch64 / arm as long as these targets are > not fully converted yet: > > Exception: contradiction between clauses when setting VIRTIO_MMIO > make: *** No rule to make target `aarch64-softmmu/config-devices.mak', > needed by `config-all-devices.mak'. Stop. > > I think you temporarily have not to set CONFIG_VIRTIO=y in > default-configs/arm-softmmu.mak (and likely also in the riscv and s390x > configs), until they are finally converted completely? > Hello Thomas, We did not defaultly enable VIRTIO for all ARCHs, and oonly enable this from host bridge. CONFIG_VIRTIO=y is defined in pci.mak, which is not enabled for all ARCHs.
./hw/pci-host/Kconfig config PCI_PIIX bool select PCI select VIRTIO config PCI_EXPRESS_Q35 bool select PCI_EXPRESS select PCI select XIO3130 select IOH3420 select I82801B11 select VIRTIO Yang > Thomas