On 2019-01-25 11:07, Paolo Bonzini wrote: > This way, the default-configs file only need to specify the boards > and any optional devices. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Yang Zhong <yang.zh...@intel.com> > Message-Id: <20190123065618.3520-37-yang.zh...@intel.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- [...] > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index ff41be3..8814b7c 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -5,20 +5,73 @@ config SEV > config PC > bool > > +config PC > + bool > + select ISA_DEBUG > + select I8259 > + select I8254 > + select PCSPK > + select I82374 > + select I8257 > + select MC146818RTC
You've duplicated the "config PC" line here. The "select"s should be added to the previous "config PC" section instead. Thomas
