Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' b0d91d5c95 target/riscv: Remaining rvc insn reuse 32 bit translators 7206dcc84c target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 b2503c4a5d target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 8a29c8d73f target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns dfff5221bb target/riscv: Convert @cs_2 insns to share translation functions 6bd1806e46 target/riscv: Remove decode_RV32_64G() 5d8486984d target/riscv: Remove gen_system() 9398d224da target/riscv: Rename trans_arith to gen_arith f46f9d3b7e target/riscv: Remove manual decoding of RV32/64M insn 4f99b16403 target/riscv: Remove shift and slt insn manual decoding 4b7a37bf50 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists d5dff5bb4f target/riscv: Move gen_arith_imm() decoding into trans_* functions cdd18b5fd3 target/riscv: Remove manual decoding from gen_store() 02662360b2 target/riscv: Remove manual decoding from gen_load() bd16560117 target/riscv: Remove manual decoding from gen_branch() 38dd04479d target/riscv: Remove gen_jalr() f60b6e585d target/riscv: Convert quadrant 2 of RVXC insns to decodetree 6696503c0b target/riscv: Convert quadrant 1 of RVXC insns to decodetree 798ef76c96 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 5a39fc2a0e target/riscv: Convert RV priv insns to decodetree 1f1f8c9bc3 target/riscv: Convert RV64D insns to decodetree d1c0ab7fe1 target/riscv: Convert RV32D insns to decodetree c6e274a4d5 target/riscv: Convert RV64F insns to decodetree 6c51feecdd target/riscv: Convert RV32F insns to decodetree 577e399bd4 target/riscv: Convert RV64A insns to decodetree c4fef55a8d target/riscv: Convert RV32A insns to decodetree fdbec6cffa target/riscv: Convert RVXM insns to decodetree d9ed27a651 target/riscv: Convert RVXI csr insns to decodetree 591b4a364c target/riscv: Convert RVXI fence insns to decodetree 3fcba6a869 target/riscv: Convert RVXI arithmetic insns to decodetree de26410380 target/riscv: Convert RV64I load/store insns to decodetree 15edfa7b53 target/riscv: Convert RV32I load/store insns to decodetree aedd230ba2 target/riscv: Convert RVXI branch insns to decodetree 52f4c244c6 target/riscv: Activate decodetree and implemnt LUI & AUIPC 669f7c2086 target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit 669f7c2086d5 (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit 52f4c244c6bb (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit aedd230ba257 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit 15edfa7b53d2 (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit de26410380cd (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 3fcba6a869c8 (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit 591b4a364c72 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit d9ed27a651b0 (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit fdbec6cffaa5 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit c4fef55a8df1 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit 577e399bd4e6 (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit 6c51feecddb7 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit c6e274a4d549 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit d1c0ab7fe104 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit 1f1f8c9bc321 (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 5a39fc2a0ed0 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 798ef76c9652 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit 6696503c0b2b (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit f60b6e585df6 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 38dd04479d3a (target/riscv: Remove gen_jalr()) 21/35 Checking commit bd16560117e3 (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit 02662360b2a0 (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit cdd18b5fd3f3 (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit d5dff5bb4f95 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit 4b7a37bf50cc (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 4f99b16403cd (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit f46f9d3b7e91 (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit 9398d224da90 (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 5d8486984d26 (target/riscv: Remove gen_system()) 30/35 Checking commit 6bd1806e46e5 (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit dfff5221bb2c (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit 8a29c8d73fba (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit b2503c4a5d2f (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit 7206dcc84c13 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit b0d91d5c9510 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
