Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 5d3e748344 target/riscv: Remaining rvc insn reuse 32 bit translators 4ebbf1dcb0 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 d254063f14 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 aa3dbf3a29 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns a3eff7f3ed target/riscv: Convert @cs_2 insns to share translation functions f7b24d5062 target/riscv: Remove decode_RV32_64G() cbb2c77bce target/riscv: Remove gen_system() 3bbe000ac1 target/riscv: Rename trans_arith to gen_arith 41b7b724e1 target/riscv: Remove manual decoding of RV32/64M insn 8c5199bde1 target/riscv: Remove shift and slt insn manual decoding 3f525d4302 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 8949ae2959 target/riscv: Move gen_arith_imm() decoding into trans_* functions 0269cfffef target/riscv: Remove manual decoding from gen_store() 98e5879319 target/riscv: Remove manual decoding from gen_load() a02ae5f469 target/riscv: Remove manual decoding from gen_branch() fefcf6d2fb target/riscv: Remove gen_jalr() 01532a82e7 target/riscv: Convert quadrant 2 of RVXC insns to decodetree d232ba560a target/riscv: Convert quadrant 1 of RVXC insns to decodetree 165d8337fa target/riscv: Convert quadrant 0 of RVXC insns to decodetree 25c307af64 target/riscv: Convert RV priv insns to decodetree 511cb46131 target/riscv: Convert RV64D insns to decodetree 62ffbad8f1 target/riscv: Convert RV32D insns to decodetree 8caabe5e65 target/riscv: Convert RV64F insns to decodetree 20004c0268 target/riscv: Convert RV32F insns to decodetree 38300733ef target/riscv: Convert RV64A insns to decodetree bde575d56d target/riscv: Convert RV32A insns to decodetree d37bad2de8 target/riscv: Convert RVXM insns to decodetree 0c9508a7ec target/riscv: Convert RVXI csr insns to decodetree a6b3d65e3e target/riscv: Convert RVXI fence insns to decodetree 1e1292029e target/riscv: Convert RVXI arithmetic insns to decodetree de7f337b02 target/riscv: Convert RV64I load/store insns to decodetree 2a2ed84b3c target/riscv: Convert RV32I load/store insns to decodetree eb157fbcca target/riscv: Convert RVXI branch insns to decodetree 56bb22ad3e target/riscv: Activate decodetree and implemnt LUI & AUIPC b6c4484f90 target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit b6c4484f903d (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit 56bb22ad3e17 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit eb157fbccad3 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit 2a2ed84b3ca7 (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit de7f337b0271 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 1e1292029e37 (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit a6b3d65e3e38 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit 0c9508a7ec9b (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit d37bad2de864 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit bde575d56df6 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit 38300733ef03 (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit 20004c02680b (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit 8caabe5e6513 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit 62ffbad8f168 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit 511cb461313f (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 25c307af643b (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 165d8337fac5 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit d232ba560abf (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit 01532a82e755 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit fefcf6d2fb01 (target/riscv: Remove gen_jalr()) 21/35 Checking commit a02ae5f4694e (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit 98e5879319ca (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit 0269cfffef18 (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit 8949ae2959ea (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit 3f525d4302db (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 8c5199bde10b (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit 41b7b724e122 (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit 3bbe000ac102 (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit cbb2c77bce3c (target/riscv: Remove gen_system()) 30/35 Checking commit f7b24d5062da (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit a3eff7f3ed3e (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit aa3dbf3a29e8 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit d254063f1463 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit 4ebbf1dcb057 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit 5d3e748344c1 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
