On 1/30/19 1:17 AM, Thomas Huth wrote: >> test ... -a ... >> >> is not portable (POSIX permits non-XSI systems to omit support for these >> operators, but even where they are supported, there are some inherently >> ambiguous inputs where you CANNOT predict whether the shell will parse >> -a as a binary operator or as an argument to some other operator). >> Instead, you should ALWAYS break dual tests into: >> >> test ... && test ... >> >> instead. (Same for '-o' vs '|| test') > > $ grep 'test.* -a ' configure | wc -l > 21 > $ grep 'test.* && ' configure | wc -l > 16 > > Looks like we do not really care?
Well, I care. Enough to propose a patch :) https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00960.html -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
