Juan Quintela <quint...@redhat.com> writes: > Eric Blake <ebl...@redhat.com> wrote: >> On 1/30/19 6:06 AM, Juan Quintela wrote: >>> It will be used to store the uri parameters. We want this only for >>> tcp, so we don't set it for other uris. We need it to know what port >>> is migration running. >>> >>> Signed-off-by: Juan Quintela <quint...@redhat.com> [...] >>> @@ -199,6 +200,8 @@ >>> # @compression: migration compression statistics, only returned if >>> compression >>> # feature is on and status is 'active' or 'completed' (Since 3.1) >>> # >>> +# @socket-address: Only used for tcp, to know what the real port is (Since >>> 3.1) >>> +# >> >> s/3.1/4.0/ > > Done. > >>> +## >>> +# @DummyStruct: >>> +# >>> +# Both block-core and migration needs SocketAddressList >>> +# I am open to comments about how to share it >>> +# >>> +# @dummy-list: A dummy list >>> +# >>> +# Since: 3.1 >> >> s/3.1/4.0/ >> This matches how we force list types elsewhere for use in C code even >> when the type is not exposed through QMP. But do you still need to force >> the generation, given that ['SocketAddress'] used in MigrationInfo is >> visible through QMP? > > I think so but I am not an expert here.
If the list type is visible in QMP, we shouldn't add this hack to force it. Easy to find out: drop DummyStruct, and if it still compiles, the forcing needs to go.
