On Sun, 10 Feb 2019 at 22:03, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Why do you think it should be a submodule? That's the approach I > proposed first, but Daniel suggested to make it immediately a shared > library if possible.
It needs to be a submodule because you don't have a time machine to arrange for it to be an available package in all the stable versions of the distros we support. As and when it is packaged in the oldest stable versions we care about, we can drop the submodule, but submodule is where we need to start. (This is the same as we did with third party bits of code like pixman.) I think immediately going for the shared library (as opposed to static) is a bit of a bold decision also because it is a hard commitment to API and ABI compatibility, which previously has been something the slirp code didn't need to care about at all. > Regarding the build system, if meson/ninja is problematic for some > distro, we can come up with autotools or plain Make for a while. I think plain make would be more convenient. Otherwise everybody building QEMU needs to install a random extra build tool. thanks -- PMM
