On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: > On 03/23/11 14:19, Alon Levy wrote: > > A CCID device is a smart card reader. It is a USB device, defined at [1]. > > This patch introduces the usb-ccid device that is a ccid bus. Next patches > > will > > introduce two card types to use it, a passthru card and an emulated card. > > > > [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_Rev110. > > > > Signed-off-by: Alon Levy <al...@redhat.com> > > This looks ok to me now - I noticed that the comments in the header file > refers to u8/u16/u32 for types, even though the code uses > uint{8,16,32}_t, but I don't think that warrants a fix.
You mean the comments in hw/usb-ccid.c in the descriptor? that's just shorter. > > If the comment goes in, please fix the spelling of my name. > > Reviewed-by: Jes Sorensen <jes.soren...@redhat.com> >