On Mon, Mar 28, 2011 at 5:31 PM, Jes Sorensen <jes.soren...@redhat.com> wrote: > On 03/28/11 16:28, Alon Levy wrote: >> On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote: >>> > On 03/23/11 14:19, Alon Levy wrote: >>>> > > A CCID device is a smart card reader. It is a USB device, defined at >>>> > > [1]. >>>> > > This patch introduces the usb-ccid device that is a ccid bus. Next >>>> > > patches will >>>> > > introduce two card types to use it, a passthru card and an emulated >>>> > > card. >>>> > > >>>> > > [1] >>>> > > http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_Rev110. >>>> > > >>>> > > Signed-off-by: Alon Levy <al...@redhat.com> >>> > >>> > This looks ok to me now - I noticed that the comments in the header file >>> > refers to u8/u16/u32 for types, even though the code uses >>> > uint{8,16,32}_t, but I don't think that warrants a fix. >> You mean the comments in hw/usb-ccid.c in the descriptor? that's just >> shorter. > > I wasn't sure if it was a leftover from some of the headers being used > in the kernel. However I am fine with it - no need to change it, and it > makes it shorter as you say.
No, u8/u16 etc are only available for Linux. Please use standard uint8_t etc. See also HACKING 2.1.
