On 19-03-01 14:59:00, Peter Xu wrote: > On Thu, Feb 28, 2019 at 09:47:56PM +0800, Yi Sun wrote: > > From: "Liu, Yi L" <[email protected]> > > > > Per Intel(R) VT-d 3.0, the qi_desc is 256 bits in Scalable > > Mode. This patch adds emulation of 256bits qi_desc. > > > > Signed-off-by: Liu, Yi L <[email protected]> > > [Yi Sun is co-developer to rebase and refine the patch.] > > Signed-off-by: Yi Sun <[email protected]> > > [...] > > > @@ -2501,7 +2507,12 @@ static void vtd_handle_iqt_write(IntelIOMMUState *s) > > { > > uint64_t val = vtd_get_quad_raw(s, DMAR_IQT_REG); > > > > - s->iq_tail = VTD_IQT_QT(val); > > + if (s->iq_dw && val & VTD_IQT_QT_256_RSV_BIT) { > > Nit: Let's do (val & VTD_IQT_QT_256_RSV_BIT) to be clear. With that: > Sure. Thanks!
> Reviewed-by: Peter Xu <[email protected]> > > Regards, > > -- > Peter Xu
