Hello, Marc-André Lureau, le mer. 13 mars 2019 18:35:09 +0100, a ecrit: > On Wed, Mar 13, 2019 at 6:32 PM Eric Blake <ebl...@redhat.com> wrote: > > > > On 3/13/19 11:42 AM, Marc-André Lureau wrote: > > > In order to make slirp a standalone project, the project must have a > > > clear license, and be compatible with the GPL or LGPL. > > > > > > Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the > > > advertising clause from the slirp license"), slirp is BSD-3. But new > > > files have been added under slirp/ with QEMU GPL license since then. > > > > > > The copyright holders have been asked to relicense files to BSD-3 and > > > gave their permission: > > > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > > > > > > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > > --- > > > slirp/src/dhcpv6.h | 31 +++++++++++++++++++++++++++++-- > > > slirp/src/ncsi-pkt.h | 33 +++++++++++++++++++++++++++++---- > > > slirp/src/vmstate.h | 42 +++++++++++++++++++++++++++--------------- > > > slirp/src/dhcpv6.c | 37 +++++++++++++++++++++++++++---------- > > > slirp/src/ncsi.c | 31 +++++++++++++++++++++++++++++-- > > > slirp/src/vmstate.c | 31 +++++++++++++++++++++++++++++-- > > > 6 files changed, 170 insertions(+), 35 deletions(-) > > > > Are we trying to split slirp off in time for 4.0, or are we at the point > > where it remains embedded until 4.1? > > I don't know what Samuel, Peter and others think about it.
I'd say since the source seems ready we can try for 4.0, but I let general qemu maintainers consider what they prefer. > If we don't have code change, but only move slirp/ to a submodule, is > that acceptable during soft-freeze? > > Fwiw, we are mostly ready to do that, we mostly need the repo creation > now (https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/119)