Patchew URL: https://patchew.org/QEMU/cover.1554755001.git.stephen.checko...@oberlin.edu/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: cover.1554755001.git.stephen.checko...@oberlin.edu Subject: [Qemu-devel] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/cover.1554755001.git.stephen.checko...@oberlin.edu -> patchew/cover.1554755001.git.stephen.checko...@oberlin.edu Switched to a new branch 'test' b0552d6d4b block/pflash_cfi02: Use the chip erase time specified in the CFI table e8c5cb8285 block/pflash_cfi02: Implement erase suspend/resume 06ea827393 block/pflash_cfi02: Implement multi-sector erase 6cfd6f4112 block/pflash_cfi02: Fix reset command not ignored during erase a2dd176ca2 block/pflash_cfi02: Fix CFI in autoselect mode d6aac26497 block/pflash_cfi02: Implement nonuniform sector sizes 7823825a45 block/pflash_cfi02: Implement intereleaved flash devices 0e8320e578 block/pflash_cfi02: Fix command address comparison 2d86dbe9a5 block/pflash_cfi02: Refactor, NFC intended ef5bc94219 block/pflash_cfi02: Add test for supported commands === OUTPUT BEGIN === 1/10 Checking commit ef5bc9421964 (block/pflash_cfi02: Add test for supported commands) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: spaces required around that '*' (ctx:VxV) #67: FILE: tests/pflash-cfi02-test.c:21: +#define MP_FLASH_SIZE_MAX (32*1024*1024) ^ ERROR: spaces required around that '*' (ctx:VxV) #67: FILE: tests/pflash-cfi02-test.c:21: +#define MP_FLASH_SIZE_MAX (32*1024*1024) ^ ERROR: spaces required around that '-' (ctx:VxV) #68: FILE: tests/pflash-cfi02-test.c:22: +#define BASE_ADDR (0x100000000ULL-MP_FLASH_SIZE_MAX) ^ ERROR: spaces required around that '*' (ctx:VxV) #71: FILE: tests/pflash-cfi02-test.c:25: +#define CFI_ADDR (FLASH_WIDTH*0x55) ^ ERROR: spaces required around that '*' (ctx:VxV) #72: FILE: tests/pflash-cfi02-test.c:26: +#define UNLOCK0_ADDR (FLASH_WIDTH*0x5555) ^ ERROR: spaces required around that '*' (ctx:VxV) #73: FILE: tests/pflash-cfi02-test.c:27: +#define UNLOCK1_ADDR (FLASH_WIDTH*0x2AAA) ^ ERROR: spaces required around that '*' (ctx:VxV) #162: FILE: tests/pflash-cfi02-test.c:116: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x0000), ==, 0x00BF); ^ ERROR: spaces required around that '*' (ctx:VxV) #163: FILE: tests/pflash-cfi02-test.c:117: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x0001), ==, 0x236D); ^ ERROR: spaces required around that '*' (ctx:VxV) #168: FILE: tests/pflash-cfi02-test.c:122: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x10), ==, 'Q'); ^ ERROR: spaces required around that '*' (ctx:VxV) #169: FILE: tests/pflash-cfi02-test.c:123: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x11), ==, 'R'); ^ ERROR: spaces required around that '*' (ctx:VxV) #170: FILE: tests/pflash-cfi02-test.c:124: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x12), ==, 'Y'); ^ WARNING: line over 80 characters #171: FILE: tests/pflash-cfi02-test.c:125: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x2C), >=, 1); /* Num erase regions. */ ERROR: spaces required around that '*' (ctx:VxV) #171: FILE: tests/pflash-cfi02-test.c:125: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x2C), >=, 1); /* Num erase regions. */ ^ ERROR: spaces required around that '*' (ctx:VxV) #172: FILE: tests/pflash-cfi02-test.c:126: + uint32_t nb_sectors = flash_read(FLASH_WIDTH*0x2D) + ^ ERROR: spaces required around that '*' (ctx:VxV) #173: FILE: tests/pflash-cfi02-test.c:127: + (flash_read(FLASH_WIDTH*0x2E) << 8) + 1; ^ ERROR: spaces required around that '*' (ctx:VxV) #174: FILE: tests/pflash-cfi02-test.c:128: + uint32_t sector_len = (flash_read(FLASH_WIDTH*0x2F) << 8) + ^ ERROR: spaces required around that '*' (ctx:VxV) #175: FILE: tests/pflash-cfi02-test.c:129: + (flash_read(FLASH_WIDTH*0x30) << 16); ^ ERROR: spaces required around that '*' (ctx:VxV) #254: FILE: tests/pflash-cfi02-test.c:208: + if (ftruncate(fd, 8*1024*1024) < 0) { ^ ERROR: spaces required around that '*' (ctx:VxV) #254: FILE: tests/pflash-cfi02-test.c:208: + if (ftruncate(fd, 8*1024*1024) < 0) { ^ total: 18 errors, 2 warnings, 238 lines checked Patch 1/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/10 Checking commit 2d86dbe9a56f (block/pflash_cfi02: Refactor, NFC intended) ERROR: spaces required around that '?' (ctx:VxW) #101: FILE: hw/block/pflash_cfi02.c:172: + uint64_t ret = pfl->be? ldn_be_p(p, width) : ldn_le_p(p, width); ^ total: 1 errors, 0 warnings, 340 lines checked Patch 2/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/10 Checking commit 0e8320e578b1 (block/pflash_cfi02: Fix command address comparison) ERROR: spaces required around that '*' (ctx:VxV) #55: FILE: tests/pflash-cfi02-test.c:26: +#define UNLOCK0_ADDR (FLASH_WIDTH*0x555) ^ ERROR: spaces required around that '*' (ctx:VxV) #56: FILE: tests/pflash-cfi02-test.c:27: +#define UNLOCK1_ADDR (FLASH_WIDTH*0x2AA) ^ ERROR: spaces required around that '*' (ctx:VxV) #65: FILE: tests/pflash-cfi02-test.c:195: + flash_write(FLASH_WIDTH*0x5555, UNLOCK0_CMD); ^ ERROR: spaces required around that '*' (ctx:VxV) #66: FILE: tests/pflash-cfi02-test.c:196: + flash_write(FLASH_WIDTH*0x2AAA, UNLOCK1_CMD); ^ ERROR: spaces required around that '*' (ctx:VxV) #67: FILE: tests/pflash-cfi02-test.c:197: + flash_write(FLASH_WIDTH*0x5555, AUTOSELECT_CMD); ^ ERROR: spaces required around that '*' (ctx:VxV) #68: FILE: tests/pflash-cfi02-test.c:198: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x0000), ==, 0x00BF); ^ ERROR: spaces required around that '*' (ctx:VxV) #69: FILE: tests/pflash-cfi02-test.c:199: + g_assert_cmpint(flash_read(FLASH_WIDTH*0x0001), ==, 0x236D); ^ total: 7 errors, 0 warnings, 48 lines checked Patch 3/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/10 Checking commit 7823825a45cc (block/pflash_cfi02: Implement intereleaved flash devices) ERROR: if this code is redundant consider removing it #214: FILE: hw/block/pflash_cfi02.c:300: +#if 0 total: 1 errors, 0 warnings, 995 lines checked Patch 4/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/10 Checking commit d6aac264973d (block/pflash_cfi02: Implement nonuniform sector sizes) 6/10 Checking commit a2dd176ca2b6 (block/pflash_cfi02: Fix CFI in autoselect mode) 7/10 Checking commit 6cfd6f4112db (block/pflash_cfi02: Fix reset command not ignored during erase) ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 9 lines checked Patch 7/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/10 Checking commit 06ea82739330 (block/pflash_cfi02: Implement multi-sector erase) 9/10 Checking commit e8c5cb8285b4 (block/pflash_cfi02: Implement erase suspend/resume) 10/10 Checking commit b0552d6d4bf2 (block/pflash_cfi02: Use the chip erase time specified in the CFI table) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1554755001.git.stephen.checko...@oberlin.edu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com