On 09/04/2019 17.37, Stephen Checkoway wrote: > > > On Apr 9, 2019, at 02:13, Thomas Huth <th...@redhat.com> wrote: > >> We'd like to get rid of global_qtest in the long run (since it is >> causing trouble for tests that run multiple instances of QEMU in >> parallel, e.g. migration tests)... so if it is feasible, please don't >> use it in new code anymore. Try to use a local variable in the function >> that call qtest_initf() and pass the test state around via a parameter >> to the functions that need it. > > One of the patches introduces a FlashConfig structure which gets passed > around to all the functions. I could stuff the local qtest in there. The > earlier patches would still use global_qtest. Would that be acceptable or > would you prefer that global_qtest not appear in any of the patches?
Using FlashConfig sounds fine to me. If you need to use global_qtest in some of the earlier patches, that's ok, too (especially if these go away again in the later patches ;-)). Thomas
