Patchew URL: https://patchew.org/QEMU/20190424124414.17775-1-ari...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190424124414.17775-1-ari...@gmail.com Subject: [Qemu-devel] [PATCH v1] gdbstub: Refactor gdb packets handler === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 85947dafad..c4e9f845f6 master -> master * [new tag] patchew/20190424124414.17775-1-ari...@gmail.com -> patchew/20190424124414.17775-1-ari...@gmail.com Switched to a new branch 'test' 5d56162098 gdbstub: Refactor gdb packets handler === OUTPUT BEGIN === ERROR: braces {} are necessary for all arms of this statement #90: FILE: gdbstub.c:1316: + if (!schema) [...] ERROR: consider using qemu_strtoull in preference to strtoull #107: FILE: gdbstub.c:1333: + params[curr_param].val_ull = strtoull(curr_data, WARNING: Block comments use a leading /* on a separate line #153: FILE: gdbstub.c:1379: + char str_buf[MAX_PACKET_LENGTH + 1 /* trailing NUL */]; ERROR: spaces prohibited around that ':' (ctx:WxW) #189: FILE: gdbstub.c:1415: + int cmd_startswith : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #190: FILE: gdbstub.c:1416: + int cmd_full_match : 1; ^ ERROR: braces {} are necessary for all arms of this statement #207: FILE: gdbstub.c:1433: + if (!cmds) [...] ERROR: braces {} are necessary for all arms of this statement #220: FILE: gdbstub.c:1446: + if (schema_len % 2) [...] WARNING: Block comments use a leading /* on a separate line #258: FILE: gdbstub.c:1484: + /* Remove all the breakpoints when this query is issued, WARNING: Block comments should align the * on each line #259: FILE: gdbstub.c:1485: + /* Remove all the breakpoints when this query is issued, + * because gdb is doing and initial connect and the state ERROR: braces {} are necessary for all arms of this statement #267: FILE: gdbstub.c:1493: + if (gdb_ctx->num_params) [...] ERROR: braces {} are necessary for all arms of this statement #278: FILE: gdbstub.c:1504: + if (gdb_ctx->num_params) [...] ERROR: braces {} are necessary for all arms of this statement #282: FILE: gdbstub.c:1508: + if (gdb_ctx->s->signal == -1) [...] ERROR: braces {} are necessary for all arms of this statement #296: FILE: gdbstub.c:1522: + if (!gdb_ctx->num_params) [...] ERROR: braces {} are necessary for all arms of this statement #314: FILE: gdbstub.c:1540: + if (!gdb_ctx->num_params) [...] ERROR: braces {} are necessary for all arms of this statement #318: FILE: gdbstub.c:1544: + if (!process) [...] ERROR: braces {} are necessary for all arms of this statement #322: FILE: gdbstub.c:1548: + if (!cpu) [...] ERROR: do not use C99 // comments #345: FILE: gdbstub.c:1571: + // Order is important if has same prefix ERROR: braces {} are necessary for all arms of this statement #372: FILE: gdbstub.c:1598: + if (!gdb_ctx->num_params) [...] ERROR: braces {} are necessary for all arms of this statement #408: FILE: gdbstub.c:1634: + if (pid == gdb_get_cpu_pid(s, s->c_cpu)) [...] ERROR: braces {} are necessary for all arms of this statement #411: FILE: gdbstub.c:1637: + if (pid == gdb_get_cpu_pid(s, s->g_cpu)) [...] ERROR: braces {} are necessary for all arms of this statement #424: FILE: gdbstub.c:1650: + if (gdb_ctx->num_params) [...] ERROR: braces {} are necessary for all arms of this statement #436: FILE: gdbstub.c:1662: + if (!gdb_ctx->num_params) [...] ERROR: braces {} are necessary for all arms of this statement #443: FILE: gdbstub.c:1669: + if (!num_syscall_params) [...] ERROR: braces {} are necessary for all arms of this statement #482: FILE: gdbstub.c:1708: + if (!gdb_ctx->num_params) [...] WARNING: Block comments use a leading /* on a separate line #551: FILE: gdbstub.c:1777: + /* Older gdb are really dumb, and don't use 'g' if 'p' is avaialable. WARNING: Block comments use * on subsequent lines #552: FILE: gdbstub.c:1778: + /* Older gdb are really dumb, and don't use 'g' if 'p' is avaialable. + This works, but can be very slow. Anything new enough to WARNING: Block comments use a trailing */ on a separate line #553: FILE: gdbstub.c:1779: + understand XML also knows how to use this properly. */ ERROR: braces {} are necessary for all arms of this statement #717: FILE: gdbstub.c:1943: + if (!gdb_ctx->num_params) [...] WARNING: Block comments should align the * on each line #746: FILE: gdbstub.c:1963: + /* + * "Current thread" remains vague in the spec, so always return ERROR: braces {} are necessary for all arms of this statement #793: FILE: gdbstub.c:2010: + if (!cpu) [...] ERROR: braces {} are necessary for all arms of this statement #869: FILE: gdbstub.c:2086: + if (gdb_ctx->num_params && strstr(gdb_ctx->params[0].data, "multiprocess+")) [...] ERROR: braces {} are necessary for all arms of this statement #912: FILE: gdbstub.c:2129: + if (len > (MAX_PACKET_LENGTH - 5) / 2) [...] ERROR: braces {} are necessary for all arms of this statement #1019: FILE: gdbstub.c:2236: + if (!gdb_ctx->num_params) [...] ERROR: code indent should never use tabs #1025: FILE: gdbstub.c:2242: +^I^Ireturn;$ ERROR: code indent should never use tabs #1026: FILE: gdbstub.c:2243: +^I}$ ERROR: braces {} are necessary for all arms of this statement #1037: FILE: gdbstub.c:2254: + if (!gdb_ctx->num_params) [...] ERROR: code indent should never use tabs #1043: FILE: gdbstub.c:2260: +^I^Ireturn;$ ERROR: code indent should never use tabs #1044: FILE: gdbstub.c:2261: +^I}$ ERROR: code indent should never use tabs #1046: FILE: gdbstub.c:2263: +^Iput_packet(gdb_ctx->s, "");$ total: 32 errors, 7 warnings, 1671 lines checked Commit 5d56162098f9 (gdbstub: Refactor gdb packets handler) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190424124414.17775-1-ari...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
