Jon Doron <ari...@gmail.com> writes:
> Refactor the command packet handling code to ease the work of > adding and extending commands that are currently not implemented. > > Signed-off-by: Jon Doron <ari...@gmail.com> > --- > gdbstub.c | 1577 +++++++++++++++++++++++++++++++++++++---------------- > 1 file changed, 1092 insertions(+), 485 deletions(-) This is worthwhile but the patch is huge compared to recent changes to this currently orphaned file. Could you please consider splitting your patch up into more discreet parts. I would suggest: - introduce infrastructure - one patch per converted command this way when something breaks bisect stands a better chance of locating a minimal failing chunk of code. Out of interest what additional commands are you planning to implement? -- Alex Bennée
