Patchew URL: https://patchew.org/QEMU/20190425200051.19906-1-ehabk...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190425200051.19906-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] Remove some qdev_get_machine() calls from CONFIG_USER_ONLY === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190424004700.12766-1-richardw.y...@linux.intel.com -> patchew/20190424004700.12766-1-richardw.y...@linux.intel.com * [new tag] patchew/20190425200051.19906-1-ehabk...@redhat.com -> patchew/20190425200051.19906-1-ehabk...@redhat.com Switched to a new branch 'test' c5c77ea2cc qdev-hotplug: Don't check type of qdev_get_machine() 854ded711d qdev: Don't compile hotplug code in user-mode emulation 1bd33307be move qdev hotplug code to qdev-hotplug.c 02b1f5db6f machine: Move gpio code to hw/core/gpio.c === OUTPUT BEGIN === 1/4 Checking commit 02b1f5db6fcd (machine: Move gpio code to hw/core/gpio.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #60: FILE: hw/core/gpio.c:30: + /* NULL is a valid and matchable name, otherwise do a normal WARNING: Block comments use a leading /* on a separate line #156: FILE: hw/core/gpio.c:126: + /* We need a name for object_property_set_link to work. If the ERROR: "foo * bar" should be "foo *bar" #205: FILE: hw/core/gpio.c:175: +void qdev_connect_gpio_out(DeviceState * dev, int n, qemu_irq pin) total: 1 errors, 3 warnings, 403 lines checked Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/4 Checking commit 1bd33307be11 (move qdev hotplug code to qdev-hotplug.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 total: 0 errors, 1 warnings, 134 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit 854ded711daa (qdev: Don't compile hotplug code in user-mode emulation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 77 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit c5c77ea2ccde (qdev-hotplug: Don't check type of qdev_get_machine()) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190425200051.19906-1-ehabk...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com