On 25/04/19 22:00, Eduardo Habkost wrote: > diff --git a/hw/core/qdev-hotplug-stubs.c b/hw/core/qdev-hotplug-stubs.c > new file mode 100644 > index 0000000000..c710f23388 > --- /dev/null > +++ b/hw/core/qdev-hotplug-stubs.c > @@ -0,0 +1,44 @@ > +/* > + * qdev hotplug handler stubs (for user-mode emulation and unit tests)
Can you explain the issue with unit tests in the commit message? > + * Copyright (c) 2019 Red Hat Inc > + * > + * Authors: > + * Eduardo Habkost <ehabk...@redhat.com> > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, see > <http://www.gnu.org/licenses/>. > + */ > + > +#include "qemu/osdep.h" > +#include "hw/qdev-core.h" > +#include "hw/hotplug.h" > + > +HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev) > +{ > + return NULL; > +} > + > +void hotplug_handler_pre_plug(HotplugHandler *plug_handler, > + DeviceState *plugged_dev, > + Error **errp) > +{ > + assert(plug_handler == NULL); > +} > + > +void hotplug_handler_plug(HotplugHandler *plug_handler, > + DeviceState *plugged_dev, > + Error **errp) > +{ > + assert(plug_handler == NULL); > +} Would it work if you instead make these functions (and the others in hw/core/hotplug.c) inlines in include/hw/hotplug.h? Then all that remains is qdev_get_hotplug_handler. Paolo